Skip to content

Fix missing failing e2e tests #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
osenan merged 4 commits into from
Nov 27, 2025
Merged

Fix missing failing e2e tests #1447

osenan merged 4 commits into from
Nov 27, 2025

Conversation

@osenan
Copy link

@osenan osenan commented Nov 27, 2025 •
edited
Loading

Pull Request

Fixes #1440
Companion #1441

This PR contains the remaining failing e2e test of the package. I am based on the issue #1440. According to the issue 4 tests from 4 different test files are failing. I ran the test and found that actually only two of them are failing. Here the screenshot of the other two files that all test are passing:

image

Please test locally the fixed tests with the following instructions:

devtools::load_all()
library(shinytest2)
source("tests/testthat/helper-TealAppDriver.R")
source("tests/testthat/helper-testing-depth.R")
testthat::test_file("tests/testthat/test-shinytest2-tm_g_barchart_simple.R)
testthat::test_file("tests/testthat/test-shinytest2-tm_t_binary_outcome.R")

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025 •
edited
Loading


🎉 Thank you for your contribution! Before this PR can be accepted, we require that you all read and agree to our Contributor License Agreement.
You can digitally sign the CLA by posting a comment on this Pull Request in the format shown below. This agreement will apply to this PR as well as all future contributions on this repository.

I have read the CLA Document and I hereby sign the CLA

1 out of 2 committers have signed the CLA.
✅ (m7pr)[https://github.com/m7pr]
❌ @osenan
osenan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025 •
edited
Loading

Unit Tests Summary

    1 files  ±0     71 suites  ±0   2h 18m 36s ⏱️ -19s
  734 tests ±0    388 ✅ ±0  117 💤 ±0  204 ❌ ±0  25 🔥 ±0 
1 940 runs  ±0  1 455 ✅  - 1  117 💤 ±0  343 ❌ +1  25 🔥 ±0 

For more details on these failures and errors, see this check.

Results for commit 5893318. ± Comparison against base commit 40b5489.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_gee 💔 $0.23$ $+3.47$ $0$ $0$ $0$ $0$
shinytest2-tm_a_mmrm 💔 $0.66$ $+7.58$ $0$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 💔 $0.33$ $+2.61$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ci 💔 $0.20$ $+1.15$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 💔 $0.25$ $+2.64$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ipp 💔 $0.19$ $+2.74$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💔 $0.38$ $+3.04$ $0$ $0$ $0$ $0$
shinytest2-tm_g_lineplot 💔 $0.14$ $+1.13$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_adverse_events 💔 $0.25$ $+1.80$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_patient_timeline 💔 $0.37$ $+4.68$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_therapy 💔 $0.33$ $+7.09$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_vitals 💔 $0.16$ $+1.16$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality 💔 $0.13$ $+1.13$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality_by_worst_grade 💔 $0.12$ $+1.31$ $0$ $0$ $0$ $0$
shinytest2-tm_t_ancova 💔 $0.37$ $+1.96$ $0$ $0$ $0$ $0$
shinytest2-tm_t_binary_outcome 💔 $0.14$ $+1.35$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_by_grade 💔 $0.13$ $+1.46$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_summary 💔 $0.11$ $+2.40$ $0$ $0$ $0$ $0$
shinytest2-tm_t_exposure 💔 $0.13$ $+2.99$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_laboratory 💔 $0.22$ $+1.43$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_prior_medication 💔 $0.16$ $+1.47$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm 💔 $0.11$ $+1.27$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm_by_worst 💔 $0.17$ $+1.88$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_grade 💔 $0.13$ $+1.84$ $0$ $0$ $0$ $0$
shinytest2-tm_t_smq 💔 $0.11$ $+1.27$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary_by 💔 $0.15$ $+1.48$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_g_km 💀 $0.01$ $-0.01$ e2e_tm_g_km_Starts_with_specified_collapsed_additional_plot_settings.
shinytest2-tm_g_km 👶 $+0.13$ e2e_tm_g_km_Starts_with_uncollapsed_additional_plot_settings.

Results for commit 8274cc6

♻️ This comment has been updated with latest results.

@averissimo averissimo self-assigned this Nov 27, 2025
m7pr
m7pr reviewed Nov 27, 2025
View reviewed changes
@osenan @m7pr
Update tests/testthat/test-shinytest2-tm_t_binary_outcome.R
1e0e693 
Remove unnecessary comment

Co-authored-by: Marcin <[email protected]>
Signed-off-by: Oriol Senan  <[email protected]>
@osenan osenan merged commit 85ac96b into bring_tests Nov 27, 2025
8 of 20 checks passed
@osenan osenan deleted the fix-missing-tests@bring_tests branch November 27, 2025 13:46
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@m7pr m7pr m7pr approved these changes

Assignees

@averissimo averissimo

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@osenan @m7pr @averissimo @llrs-roche